fix: various faucet fixes for next #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igamigo
approved these changes
May 17, 2024
There was a problem hiding this comment.
LGTM! I think it would be good if we could add two changes:
- If the spinner is active, make sure the buttons are deactivated/don't do anything when clicked in order to avoid people spamming requests.
- Judging by the video it looks like the spinner moves the page layout a bit which is probably not ideal.
mFragaBA
reviewed
May 17, 2024
mFragaBA
reviewed
May 17, 2024
mFragaBA
reviewed
May 17, 2024
bin/faucet/src/handlers.rs
Outdated
| utils::{build_client, FaucetState}, | ||
| }; | ||
|
|
||
| const TOKEN_AMOUNT_OPTIONS: [u64; 3] = [100, 500, 1000]; |
There was a problem hiding this comment.
wasn't this already part of the config? I can still see it in miden-faucet.toml
bin/faucet/src/handlers.rs
Outdated
| @@ -23,14 +29,14 @@ struct FaucetRequest { | |||
| #[derive(Serialize)] | |||
| struct FaucetMetadataReponse { | |||
| id: String, | |||
| asset_amount_options: Vec<u64>, | |||
| asset_amount_options: [u64; 3], | |||
There was a problem hiding this comment.
why do we need the change to a fixed size array?
There was a problem hiding this comment.
This was one of the changes I left on my PR to main, but I think @tomyrd is going to roll it back into using the configuration field.
Co-authored-by: igamigo <ignacio.amigo@lambdaclass.com>
phklive
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few things related to the faucet:
maintonext.Here is a video showing the new spinner:
loading_spinner.mov