Add note type to NoteSyncRecord

[igamigo]

Basing it off of phklive-block-producer-onchain to make it simpler to test from the client.

[bobbinth]

Looks good! Thank you! I left a couple of comments inline (only one of the is actionable for now).

[bobbinth]

Looks good! Thank you!

I did just realize that we need to make one more change: in select_notes_since_block_by_tag_and_sender, we should remove the shift operations in SQL statement. We are now basically filtering by the entire tag. So, the SQL should look something like this:

SELECT
    block_num,
    batch_index,
    note_index,
    note_hash,
    sender,
    tag,
    merkle_path,
    details
FROM
    notes
WHERE
    -- find the next block which contains at least one note with a matching tag
    block_num = (
        SELECT
            block_num
        FROM
            notes
        WHERE
            tag IN rarray(?1) OR sender IN rarray(?2)) AND
            block_num > ?3
        ORDER BY
            block_num ASC
        LIMIT
            1
    ) AND
    -- filter the block's notes and return only the ones matching the requested tags
    tag IN rarray(?1) OR sender IN rarray(?2));

[bobbinth]

I don't think we need these shifts any more.

[igamigo]

I keep thinking we are persisting u16s. Fixed.

[bobbinth]

All looks good! Thank you!