Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking PR for v0.2.0 release #273

Merged
merged 29 commits into from
Apr 12, 2024
Merged

Tracking PR for v0.2.0 release #273

merged 29 commits into from
Apr 12, 2024

Conversation

bobbinth
Copy link
Contributor

This is a tracking PR for v0.2.0 release of the Miden node.

bobbinth and others added 24 commits April 11, 2024 21:44
@bobbinth
chore: update crate versions to v0.2.0
b769ee7
@phklive @hackaugusto @bobbinth
Add script to check rust versions + cleanup (#272)
2a8f37a 
* ci: turn doc warnings into errors (#259)

* remove unnecessary comments

* Add script to check rust versions

* removed versions and editions except from root, updated script

* add back cargo make doc to ci

* Added section for testing

* Fixed typo

* Set versions to 0.1.0 + inherit all infos from workspace

* Fix use of versioning

* Set individual versions for crates

* Fixed nits, code organization and updated links

* Improve naming of ci job

* Fix formatting in contributing.md

* Add task to format not only check

* Reduced indent

---------

Co-authored-by: Augusto Hack <hack.augusto@gmail.com>
@phklive @hackaugusto @bobbinth
Dockerize node (#257)
2e2813c 
* Working initial docker

* fmt

* added script

* Removed docker script + updated integration

* script works

* Need to install grpcurl

* Docker works

* Working Dockerfile

* ci: turn doc warnings into errors (#259)

* Removed makefile, removing start.sh file moving in Dockerfile

* Added bookworm + alpine + removed gcc + added caching

* Moved Dockerfile to node and added Makefile.toml

* cargo make works + builds dockerfile for node

* remove start script

* added comment regarding PID1

* Set labels at top of Dockerfile + added comments

* Added correct dependencies and explanation

* Volume works persisting db files between runs

* Added documentation

* Moved labels + enable mounting of miden-node.toml

* Added docker-run-node command + added build arguments

* Add git commit as arg to docker container

* Added spacing

---------

Co-authored-by: Augusto Hack <hack.augusto@gmail.com>
@polydez @bobbinth
Implemented nullifier tree wrapper over Smt (#275)
8d4390d 
* feat: implement nullifier tree wrapper over `Smt`

* refactor: move `NullifierTree` to separated file, renames ans small fixes

* fix: address review comments
@phklive @hackaugusto @bobbinth
Separate CI into multiple files (#278)
0a4fa39 
* ci: turn doc warnings into errors (#259)

* Separated different CI jobs in their respective files

* Add next branch in ci

* Fix wrong naming in CI + use cargo make for doc

* Fixed badge + removed unnecessary additional file

* Change naming of ci and jobs

* Fix naming

* Fix comment

---------

Co-authored-by: Augusto Hack <hack.augusto@gmail.com>
@polydez @bobbinth
refactor: small error refactoring (using 'static str instead of `St…
e22e685 
…ring`) (#281)
@hackaugusto @bobbinth
bugfix: table name is block_headers instead of block_header (#283)
bcbe4b4
@hackaugusto @bobbinth
sqlite: use bundled version to enable FK checks (#284)
a150870
@mFragaBA @bobbinth
chore: update CI action for rust install (#280)
1849787
@phklive @hackaugusto @bobbinth
Add faucet enabling testing (#270)
51fe84d 
* ci: turn doc warnings into errors (#259)

* Boilerplate done

* pushed fix for miden-client

* Fix formatting

* Pulled after client fix

* Fixed typos + added build_client fn

* Added configs + figment

* Fix client implementation in faucet + use released client

* updated cargo

* Fixed Miden node when importing Miden client, db errors

* Format files

* Added proper support of configuration file + logging

* Improved config file handling

* Removed superfluous file

* First pass at improvements

* Change naming of note

* Fixed html + added metadata endpoint

* Want to implement Display for NoteId

* Upgraded js to use async + NoteId does not impl Display in main

* cargo updated

---------

Co-authored-by: Augusto Hack <hack.augusto@gmail.com>
@polydez @bobbinth
Migration to the next version of Miden dependencies (#297)
ebdfa6c 
* feat: migration to the `next` versions of Miden dependencies

* fix: `parse_auth_inputs`

* chore: use dependencies from crates.io

* chore: update deps

* fix: compilation errors

* fix: address review comments

* fix: genesis test
@polydez @bobbinth
Implemented support for note trees in Miden node (#295)
3b42e8d 
* feat: migration to the `next` versions of Miden dependencies

* fix: address review comments

* fix: update to the latest `next`

* feat: support of `BatchNoteTree` and `BlockNoteTree`

* feat: support of `BatchNoteTree` and `BlockNoteTree`, use `batch_index` instead of encoding it into the note index

* docs: add comments in SQL for batch and note indexes
@polydez @bobbinth
On-chain accounts protobuf & domain objects (#287)
1270120 
* feat: add `account_details` table to the DB

* refactor: rename `block_number` column in nullifiers table to `block_num`

* refactor: use `BETWEEN` in interval comparison checks

* feat: implement account details protobuf messages, domain objects and conversions

* feat: (WIP) implement account details support

* feat: (WIP) implement account details support

* feat: (WIP) implement account details support

* feat: (WIP) implement account details support

* fix: db creation

* docs: remove TODO

* refactor: apply formatting

* feat: implement endpoint for getting public account details

* tests: add test for storage

* feat: add rpc endpoint for getting account details

* refactor: keep only domain object changes

* fix: compilation errors

* fix: use note tag conversion from `u64`

* refactor: remove account details protobuf messages

* fix: remove unused error invariants

* refactor: introduce `UpdatedAccount` struct

* fix: rollback details conversion

* fix: compilation error

* format: reformat using rustfmt
@mFragaBA @bobbinth
fix: include batch index in db constraint for notes (#302)
9adf0cd
@igamigo @bobbinth
fix: Send correct note index on sync response (#304)
2b609bd 
* Try fix

* Remove line

* Update mod.rs

* Remove unused conversion

* revert cargo toml
@polydez @hackaugusto @bobbinth
Added support for on-chain (public) accounts in store (#293)
3765aa6 
* feat: add `account_details` table to the DB

* refactor: rename `block_number` column in nullifiers table to `block_num`

* refactor: use `BETWEEN` in interval comparison checks

* feat: implement account details protobuf messages, domain objects and conversions

* feat: (WIP) implement account details support

* feat: (WIP) implement account details support

* feat: (WIP) implement account details support

* feat: (WIP) implement account details support

* fix: db creation

* docs: remove TODO

* refactor: apply formatting

* feat: implement endpoint for getting public account details

* tests: add test for storage

* feat: add rpc endpoint for getting account details

* refactor: keep only domain object changes

* fix: compilation errors

* fix: use note tag conversion from `u64`

* refactor: remove account details protobuf messages

* fix: remove unused error invariants

* refactor: introduce `UpdatedAccount` struct

* fix: rollback details conversion

* fix: compilation error

* feat: account details in store

* refactor: add constraint name for foreign key

* refactor: small code improvement

Co-authored-by: Augusto Hack <hack.augusto@gmail.com>

* feat: account id validation

* refactor: rename `get_account_details` to `select_*`

* feat: return serialized account details

* feat: add requirement of account id to be public in RPC

* fix: remove error message used in different PR

* fix: union account details with account and process them together

* docs: remove `GetAccountDetails` from README.md

* fix: remove unused error invariants

* fix: use `Account` instead of `AccountDetails` in store

* wip

* feat: implement `GetAccountDetails` endpoint

* docs: document `GetAccountDetails` endpoint

* refactor: simplify code, make account details optional

* fix: clippy warning

* fix: address review comments

* fix: update code to the latest miden-base

* refactor: little code improvement

---------

Co-authored-by: Augusto Hack <hack.augusto@gmail.com>
@phklive @bobbinth
Implement get_notes_by_id endpoint (#298)
2a32cc8 
* Getting notes by id works

* lint and test

* Improved comments + Added conversion from digest::Digest to NoteId

* Added rpc validation for NoteId's

* Added documentation to Readmes

* Lint

* Fixed ci problems

* Added test for endpoint + refactored sql query + improved documentation

* Fixed lint

* Order rpc and store endpoints alphabitically

* Improved documentation with gh comments
@polydez @hackaugusto @bobbinth
Implemented writing on-chain accounts details on block applying (#294)
fa24b83 
* feat: add `account_details` table to the DB

* refactor: rename `block_number` column in nullifiers table to `block_num`

* refactor: use `BETWEEN` in interval comparison checks

* feat: implement account details protobuf messages, domain objects and conversions

* feat: (WIP) implement account details support

* feat: (WIP) implement account details support

* feat: (WIP) implement account details support

* feat: (WIP) implement account details support

* fix: db creation

* docs: remove TODO

* refactor: apply formatting

* feat: implement endpoint for getting public account details

* tests: add test for storage

* feat: add rpc endpoint for getting account details

* refactor: keep only domain object changes

* fix: compilation errors

* fix: use note tag conversion from `u64`

* refactor: remove account details protobuf messages

* fix: remove unused error invariants

* refactor: introduce `UpdatedAccount` struct

* fix: rollback details conversion

* fix: compilation error

* feat: account details in store

* refactor: add constraint name for foreign key

* refactor: small code improvement

Co-authored-by: Augusto Hack <hack.augusto@gmail.com>

* feat: account id validation

* refactor: rename `get_account_details` to `select_*`

* feat: return serialized account details

* feat: add requirement of account id to be public in RPC

* fix: remove error message used in different PR

* fix: union account details with account and process them together

* docs: remove `GetAccountDetails` from README.md

* fix: remove unused error invariants

* fix: use `Account` instead of `AccountDetails` in store

* wip

* feat: implement `GetAccountDetails` endpoint

* docs: document `GetAccountDetails` endpoint

* refactor: simplify code, make account details optional

* fix: clippy warning

* fix: address review comments

* fix: update code to the latest miden-base

* refactor: little code improvement

* fix: remove error message used in different PR

* fix: compilation errors
chore: update `miden-base` dependency to fixed version
refactor: extract `apply_delta` function
fix: separate error invariant for missed details in store
fix: make account details optional
refactor: introduce `UpdatedAccount` struct
fix: avoid cloning of block data
feat: simple details validation in store
feat: rewrite `sql::upsert_accounts` to simplified work with details and update test
fix: compilation errors
feat: use serialized account details
feat: writing account details on block applying

* fix: compilation errors, update test

* refactor: rename protobuf messages

* docs: update endpoint in README.md

* tests: get rid of miden-mock dependency

* tests: get rid of winter-rand-utils dependency

* refactor: rename `AccountDetailsUpdate` to `AccountUpdateDetails`

* feat: check for account hash for new on-chain accounts

* formatting: run rustfmt

* docs: address review comments

---------

Co-authored-by: Augusto Hack <hack.augusto@gmail.com>
@igamigo @bobbinth
fix: Make code compatible with miden-base's next (#307)
0b99819 
* Refactor dependency usage

* allow(clippy::blocks_in_conditions)]
@mFragaBA @bobbinth
fix: fix create_basic_fungible_faucet and create_basic_wallet errors (#…
cf8e4fc 
…308)
@phklive @bobbinth
Add support for on-chain notes to the database (#300)
516881b 
* Getting notes by id works

* lint and test

* Improved comments + Added conversion from digest::Digest to NoteId

* Added rpc validation for NoteId's

* Added documentation to Readmes

* Lint

* Added details field to database

* Fixed ci problems

* Added details to Note type

* Added test for endpoint + refactored sql query + improved documentation

* Fixed lint

* Fixed ci with test problem

* lint

* Fix nit in migration
+ add dabase to gitignore

* Order rpc and store endpoints alphabitically

* Change name to database to prevent gitignore problems

* generated

* Changed serialized None to Null + added test

* Added documentation

* chore: force refresh of readme files

* chore: remove duplicate GetNoteById descriptions from readme files

---------

Co-authored-by: Bobbin Threadbare <bobbinth@protonmail.com>
@mFragaBA @bobbinth
fix: remove assert (#313)
04c655f
@phklive @igamigo
@polydez @bobbinth
feat: add support for on-chain notes to block-producer (#310)
0c831fb 
Co-authored-by: igamigo <ignacio.amigo@lambdaclass.com>
Co-authored-by: polydez <155382956+polydez@users.noreply.github.com>
@igamigo @bobbinth
Return absolute note index (#317)
5343fc9
@bobbinth bobbinth merged commit ef60032 into main Apr 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bobbinth @phklive @polydez @hackaugusto @mFragaBA @igamigo @Dominik1999