chore: improve SyncSummary information
#513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomyrd
force-pushed
the
tomyrd-improve-syncsummary
branch
from
9b019e5
to
1bcce5a
Compare
Comment on lines
+111
to
+129
| let notes = maybe_await!(self.get_input_notes(NoteFilter::Committed))? | ||
| .into_iter() | ||
| .chain(maybe_await!(self.get_input_notes(NoteFilter::Processing))?) | ||
| .filter(|note| { | ||
| nullifiers.contains( | ||
| &Nullifier::from_hex(note.nullifier()) | ||
| .expect("Note should have valid nullifier"), | ||
| ) | ||
| }) | ||
| .collect(); |
There was a problem hiding this comment.
This may be done in a single query, what do you think?
There was a problem hiding this comment.
Queries similar to this are made in other parts of the client. I agree that it's a good idea to merge them. I can tackle it in #489
tomyrd
force-pushed
the
tomyrd-improve-syncsummary
branch
from
1bcce5a
to
b14cbd9
Compare
SantiagoPittella
approved these changes
Sep 6, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #512
This PR changes the fields from
SyncSummaryfrom quantities to lists of elements. This information can be used to get information on the specific elements that were updated in a sync.