-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix winterfell deprecations and no-std build setup #533
Conversation
There seems to be one standing warning and some rustfmt changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
a245d66
to
b173163
Compare
@hackaugusto I've gotta remember to re-run all my checks with both stable and nightly toolchains, that's why I missed those items, sorry about that! Everything is green now, so I've gone ahead and merged, but let me know if anything else comes up related to those changes. |
Can you do the same for |
@Dominik1999 Once we merge |
@bobbinth yes, the question is if we need to fix this before we merge docs PRs. PRs that touch the docs would go to |
I think if it affecting only docs, clippy warnings are ok. |
This change addresses upstream deprecations/changes from facebook/winterfell#262 and 0xPolygonMiden/crypto#290.
As a necessary side effect of those deprecations, our no-std build setup needed to be adjusted. See the above-mentioned PRs for more info, but the gist of the change is to always build with
#![no_std]
, and enablestd
features conditionally, rather than the reverse. For the most part this has little effect on how code is actually written, aside from needing to be more explicit about imports in some cases (anything that would normally be provided by the libstd prelude).