Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add merkle path wrapper #53

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

vlopes11
Copy link
Contributor

@vlopes11 vlopes11 commented Feb 11, 2023

A Merkle path is a vector of nodes, regardless of the Merkle tree implementation.

This commit introduces an encapsulation for such vector, also to provide functionality that is common between different algorithms such as opening verification.

related issue: #36

Tasks

Tasks

Tasks

  1. good first issue

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you! I left a couple of small comments inline.

src/merkle/path.rs Outdated Show resolved Hide resolved
src/merkle/path.rs Outdated Show resolved Hide resolved
src/merkle/path.rs Outdated Show resolved Hide resolved
@vlopes11 vlopes11 force-pushed the vlopes11-36-feat-add-merkle-types branch 2 times, most recently from cb975f9 to 6bd6b9e Compare February 13, 2023 13:32
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

@vlopes11
Copy link
Contributor Author

Updating my GPG key that was out of sync (commit is the same as the approved)

A Merkle path is a vector of nodes, regardless of the Merkle tree
implementation.

This commit introduces an encapsulation for such vector, also to provide
functionality that is common between different algorithms such as
opening verification.

related issue: #36
@vlopes11 vlopes11 force-pushed the vlopes11-36-feat-add-merkle-types branch from 6bd6b9e to 21a8cbc Compare February 13, 2023 21:43
@vlopes11 vlopes11 merged commit 0c242d2 into next Feb 13, 2023
@vlopes11 vlopes11 deleted the vlopes11-36-feat-add-merkle-types branch February 13, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants