Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor merge in domain tests #47

Merged
merged 1 commit into from
Feb 1, 2023
Merged

refactor merge in domain tests #47

merged 1 commit into from
Feb 1, 2023

Conversation

0xkanekiken
Copy link
Contributor

@0xkanekiken 0xkanekiken commented Jan 31, 2023 •
edited
Loading

Describe your changes

This PR address @bobbinth's comment here.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

bobbinth
bobbinth approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

src/hash/rpo/tests.rs Outdated Show resolved Hide resolved
grjte
grjte approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@grjte grjte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for updating this! I'll let you merge it in case you want to address the minor nit I left inline

src/hash/rpo/tests.rs Outdated Show resolved Hide resolved
@0xkanekiken
tests: refactor merge_in_domain tests
37c6f00 
Signed-off-by: 0xKanekiKen <100861945+0xKanekiKen@users.noreply.github.com>
@0xkanekiken 0xkanekiken merged commit f399df5 into next Feb 1, 2023
@0xkanekiken 0xkanekiken deleted the kaneki-domain-separator branch February 1, 2023 13:21
This was referenced Feb 6, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

@grjte grjte grjte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xkanekiken @bobbinth @grjte