Rpo256: Add RpoDigest conversions #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackaugusto
commented
Apr 30, 2024
| @@ -287,8 +287,7 @@ fn test_empty_leaf_hash() { | |||
| #[test] | |||
| fn test_smt_get_value() { | |||
| let key_1: RpoDigest = RpoDigest::from([ONE, ONE, ONE, ONE]); | |||
| let key_2: RpoDigest = | |||
| RpoDigest::from([2_u32.into(), 2_u32.into(), 2_u32.into(), 2_u32.into()]); | |||
There was a problem hiding this comment.
Here is an example were backwards compatibility is broken. The compiler doesn't know the type .into() should go to, because there are new valid targets (bool, u8, u16, u32).
The fix is to remove the .into(). IMO the result is more readable.
bobbinth
approved these changes
May 3, 2024
hackaugusto
force-pushed
the
hacka-rpo-digest-conversions
branch
from
b53e4b7
to
977ebc4
Compare
|
synchronized the files |
bobbinth
reviewed
May 7, 2024
Comment on lines
+121
to
+124
| #[derive(Copy, Clone, Debug)] | ||
| pub enum RpxDigestError { | ||
| InvalidInteger, | ||
| } |
There was a problem hiding this comment.
One thing I noticed: I don't think this or the RpoDigestError are exported from the crate. This probably doesn't cause any immediate issues, but may be a good idea to export them.
Merged
bobbinth
pushed a commit
that referenced
this pull request
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
While writing the issues for the proposed trait implementations I noticed some missing conversions. This adds a bunch.
Note: This is a backwards incompatible change, because now there are multiple conversions for arrays. However, I think the new code is actually shorter and easier to use.
Checklist before requesting a review
nextaccording to naming convention.