Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: fix Vec/String warnings #280

Merged
merged 6 commits into from
Feb 22, 2024
Merged

clippy: fix Vec/String warnings #280

merged 6 commits into from
Feb 22, 2024

Conversation

hackaugusto
Copy link
Contributor

Describe your changes

This fixes the clippy warnings by using wildcard imports instead of name imports.

This requires changes downstream to winterfell, namely the boxed mod.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

@hackaugusto hackaugusto changed the title Fix tryfrom tryinto clippy: fix Vec/String warnings Feb 21, 2024
@plafer
Copy link
Contributor

plafer commented Feb 21, 2024

clippy is still red; is this expected?

@hackaugusto
Copy link
Contributor Author

clippy is still red; is this expected?

yes:

This requires changes downstream to winterfell, namely the boxed mod.

There may be something else that I missed though, but until that PR is merged and release, this will be red.

@bobbinth
Copy link
Contributor

This requires changes downstream to winterfell, namely the boxed mod.

There may be something else that I missed though, but until that PR is merged and release, this will be red.

Winterfell v0.8.1 with these changes is now on crates.io.

@bobbinth bobbinth changed the base branch from next to main February 22, 2024 02:36
Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good! I pushed a few commits which fixed the remaining errors and also rebased the branch be based on main. This way, we can release miden-crypto v0.8.1.

@bobbinth bobbinth merged commit dbab0e9 into main Feb 22, 2024
10 checks passed
@bobbinth bobbinth deleted the hacka-fix-tryfrom-tryinto branch February 22, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants