Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo to be compatible with Winterfell 0.8 #275

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

Fumuran
Copy link
Contributor

@Fumuran Fumuran commented Feb 6, 2024

This PR updates the repo to be compatible with new 0.8 version of the Winterfell.
This update contains change in creation of the Felt from the u64 (from() -> try_from().unwrap()) and a small update in serialization and deserialization of vectors of Felts and RpoDigests.

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a few small comments inline.

src/merkle/smt/full/tests.rs Outdated Show resolved Hide resolved
src/merkle/tiered_smt/tests.rs Outdated Show resolved Hide resolved
src/hash/rescue/rpo/digest.rs Outdated Show resolved Hide resolved
src/hash/rescue/rpx/digest.rs Outdated Show resolved Hide resolved
src/dsa/rpo_falcon512/signature.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Al-Kindi-0 Al-Kindi-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobbinth
Copy link
Contributor

bobbinth commented Feb 7, 2024

@Overcastan - before we merge this, we'll need to create corresponding PRs in Miden VM and potentially miden base/node/client.

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bobbinth bobbinth merged commit 29c12b6 into next Feb 14, 2024
10 checks passed
@bobbinth bobbinth deleted the andrew-integrate-winterfell branch February 14, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants