Implement Smt struct (replacement to TieredSmt)
#254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
bobbinth
approved these changes
Jan 19, 2024
src/merkle/smt/full/tests.rs
Outdated
| #[test] | ||
| fn test_smt_insert_at_same_key_2() { | ||
| let key_already_present: RpoDigest = { | ||
| let raw = 0b_01101001_01101100_00011111_11111111_10010110_10010011_11100000_00000000_u64; |
There was a problem hiding this comment.
nit: I think this is the same value as the one on line 75 below (it took me some time to understand this). I'm not sure there is a big benefit to using binary representation here and it actually makes this a bit more difficult to follow. I'd probably use just decimal values for this.
There was a problem hiding this comment.
right - cleaned it up
|
bobbinth
approved these changes
Jan 19, 2024
This was referenced Jan 22, 2024
bobbinth
pushed a commit
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #245