Partial Merkle tree implementation #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fumuran
force-pushed
the
andrew-partial-mt
branch
4 times, most recently
from
ee270c1
to
10b0532
Compare
bobbinth
requested changes
May 31, 2023
bobbinth
requested changes
Jun 2, 2023
Fumuran
force-pushed
the
andrew-partial-mt
branch
2 times, most recently
from
a2ee4db
to
69df6ed
Compare
bobbinth
requested changes
Jun 5, 2023
Fumuran
force-pushed
the
andrew-partial-mt
branch
2 times, most recently
from
9197420
to
6f0c749
Compare
bobbinth
reviewed
Jun 5, 2023
Fumuran
force-pushed
the
andrew-partial-mt
branch
from
c439bcc
to
218a64b
Compare
bobbinth
requested changes
Jun 8, 2023
Fumuran
force-pushed
the
andrew-partial-mt
branch
from
e7f63bd
to
766702e
Compare
bobbinth
requested changes
Jun 13, 2023
There was a problem hiding this comment.
Thank you! Looks good. I left a few more comments inline. Also, a couple of general comments about tests:
- When a test has several things that it is doing, it would be good to have a brief comment explaining what is being tested.
- We should probably add tests for error conditions. For example, adding two Merkle paths which resolve to different roots should be an error.
bobbinth
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of basic functionality for Partial Merkle tree similar to Sparse Merkle tree.
(De)serialization of this structure will be implemented in future PR.