Feature/real sp1 verifier #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlosMata
requested review from
invocamanman,
ignasirv and
laisolizq
as code owners
invocamanman
reviewed
Oct 7, 2024
tools/addRollupType/addRollupType.ts
Outdated
| if (!isPessimistic) { | ||
| // checks for rollups | ||
| // Sanity checks genesisRoot | ||
| if (consensusContract) |
There was a problem hiding this comment.
why check here the consensus contract?¿
|
laisolizq
previously approved these changes
Oct 7, 2024
invocamanman
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT NOTE: this PR also includes #341
This PR does the following:
addNewRollupTypeto supportPolygonPessimisticConsensus