-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sovereign bridge implementation #330
base: feature/ongoingPP
Are you sure you want to change the base?
Conversation
f81e05d
to
bef3572
Compare
c79a5d0
to
45319de
Compare
45319de
to
e7d1432
Compare
contracts/v2/sovereignChains/GlobalExitRootManagerL2SovereignChain.sol
Outdated
Show resolved
Hide resolved
contracts/v2/sovereignChains/GlobalExitRootManagerL2SovereignChain.sol
Outdated
Show resolved
Hide resolved
3e47d79
to
0dc632d
Compare
contracts/v2/sovereignChains/GlobalExitRootManagerL2SovereignChain.sol
Outdated
Show resolved
Hide resolved
- Batch call function implementation to remap multiple tokens - Allow migrating legacy to updated tokens natively - Added weth mapped address are initializer
ea3cb9f
to
a73bba5
Compare
jsut run the coverage:
|
also we shoudl update the 1_create genesis deployment script to be able to put a flag "sovereign" and deploy these contracts |
Ger implementation shoould write blockHashes right?¿ probably from AggLayer or L1, to mirror the behaviour of Current Global exit root Even tho in the zkResidency we though to change that to an index to help us retrieve all the improted GERs, but that depends a lot on what impementaiton we will follow to do that. |
overall LGTM ^^ but we should do a proper review ^^ |
As an added comment i think the docker does not work since the bytecode of hte new bridge contract is too big.
We should reduce the bytecode size, the eaisest way is to put it on exceptions on harhdat and lower the optimizer runs by default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😸
3059d25
to
3e8ba6f
Compare
eda7a0f
to
af6bc64
Compare
finish injected batch data for pessimisic consensus
3e5fa9a
to
8a0f2c1
Compare
8a0f2c1
to
97609ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😸
52e4397
to
0225d15
Compare
Quality Gate passedIssues Measures |
Create Bridge and GlobalExitRootManager contracts for Sovereign chains + tests.
BridgeL2SovereignChain.sol
: extends fromPolygonZkEVMBridgeV2
with the features of:GlobalExitRootManagerL2SovereignChain.sol
: extends fromPolygonZkEVMGlobalExitRootL2
with the features of:insertGlobalExitRoot
only callable by coinbase to update the GER of a Sovereign Chain