datastream repopulation logic changes and removal of batch partially … #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…processed partially processed removed in favour of simply sealing the WIP batch on a restart
mandrigin
previously approved these changes
Aug 20, 2024
kstoykov
reviewed
Aug 21, 2024
kstoykov
reviewed
Aug 21, 2024
kstoykov
reviewed
Aug 21, 2024
kstoykov
reviewed
Aug 21, 2024
this causes timeout problems on new nodes that could spend a long time running L1 sync
|
kstoykov
approved these changes
Aug 22, 2024
hexoscott
added a commit
that referenced
this pull request
Aug 22, 2024
#992) * datastream repopulation logic changes and removal of batch partially processed partially processed removed in favour of simply sealing the WIP batch on a restart * refactor of checking for stream gap in sequencing * do not connect to datastream during startup this causes timeout problems on new nodes that could spend a long time running L1 sync * refactor of batch end logic in sequencing * tidy up and comments around new datastream handling in sequencer
Stefan-Ethernal
pushed a commit
that referenced
this pull request
Sep 20, 2024
#992) * datastream repopulation logic changes and removal of batch partially processed partially processed removed in favour of simply sealing the WIP batch on a restart * refactor of checking for stream gap in sequencing * do not connect to datastream during startup this causes timeout problems on new nodes that could spend a long time running L1 sync * refactor of batch end logic in sequencing * tidy up and comments around new datastream handling in sequencer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…processed
partially processed removed in favour of simply sealing the WIP batch on a restart