Upgrade zkevm data streamer version #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
requested review from
mandrigin,
revitteth,
cffls and
hexoscott
revitteth
reviewed
Aug 12, 2024
|
Looks great! Thanks! |
Stefan-Ethernal
force-pushed
the
fix/bump-zkevm-data-streamer-version
branch
from
b5ad402
to
d9a37a7
Compare
|
revitteth
approved these changes
Aug 12, 2024
mandrigin
pushed a commit
that referenced
this pull request
Aug 15, 2024
* Bump the zkevm-data-streamer lib version * Introduce flags * Use the tag * Fix UT * Revert imports sort in calltracer * go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates the latest changes from the zkEVM data streamer, resolving an issue related to the improper disposal of connections when non-existent data is queried from the stream (see details).
It also adds sending
CmdStopto the data streamer, when the DS client gets disposed.