Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ds data cannot be unwind #916

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

zjg555543
Copy link

@zjg555543 zjg555543 commented Aug 5, 2024

When restarting RPC erigon, ds maybe lost data. While restart rpc again, it's always failed while running UnwindIfNecessary to call TruncateFile

  • TruncateFile got an error like:Truncate not allowed, atomic operation in progress from zkevm-data-streamer
  • TruncateFile required stream.atomicOp.status == aoNone
  • So the order of StartAtomicOp and UnwindIfNecessary is adjusted here.

@cla-bot cla-bot bot added the cla-signed label Aug 5, 2024
Copy link

sonarcloud bot commented Aug 5, 2024

@mandrigin
Copy link
Collaborator

@hexoscott can you check because I thought you have been fixing something like that

@hexoscott
Copy link
Collaborator

I have this same change in the unwinds branch, we should merge this though as unwinds could take a little while.

@V-Staykov V-Staykov merged commit 2d13042 into 0xPolygonHermez:zkevm Aug 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants