add check for l2batchdata limit #691
Conversation
|
V-Staykov
deleted the
687-sequencer-batches-too-large-to-fit-into-l1-call-data
branch
| @@ -421,3 +422,45 @@ func checkForBadBatch( | |||
|
|
|||
| return false, nil | |||
| } | |||
|
|
|||
| var ( | |||
| LIMIT_128_KB = uint64(128 * 1024) | |||
There was a problem hiding this comment.
we can keep this as a constant 128_000. This is the limit in the smart contract for batchL2Data rather than "real" kb
|
|
||
| bdc.bytes = append(bdc.bytes, newBytes...) | ||
| return false | ||
| } |
There was a problem hiding this comment.
I think we can simplify this quite a bit and avoid some of the code calling this function. We only care about the size of the batchL2Data and we know every changeL2Block transaction is always 9 bytes so we can just keep a track of the number of blocks and append blockCount * 9 to the transaction bytes, which sadly does need to be fully calculated
| bytes []byte | ||
| } | ||
|
|
||
| func NewBlockDataChecker() *BlockDataChecker { |
There was a problem hiding this comment.
Maybe BatchDataSizeChecker rather than mentioning blocks?
No description provided.