forked from erigontech/erigon
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabling witness generation for bad batches #646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexoscott
force-pushed
the
witness-for-invalid-batch
branch
from
June 24, 2024 15:28
a4b5d67
to
8399772
Compare
mandrigin
reviewed
Jun 24, 2024
mandrigin
reviewed
Jun 24, 2024
mandrigin
previously approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small comment but good otherwise
hexoscott
force-pushed
the
witness-for-invalid-batch
branch
from
June 25, 2024 07:30
f30983b
to
d111d79
Compare
# Conflicts: # zk/stages/stage_sequence_execute.go
Quality Gate passedIssues Measures |
@mandrigin - I've tidied some bits up now and actioned the change in function name. How does it look now? |
mandrigin
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.