Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabling witness generation for bad batches #646

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

hexoscott
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jun 19, 2024
zk/utils/gas_limit.go Outdated Show resolved Hide resolved
zk/witness/witness.go Outdated Show resolved Hide resolved
mandrigin
mandrigin previously approved these changes Jun 24, 2024
Copy link
Collaborator

@mandrigin mandrigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment but good otherwise

@hexoscott hexoscott marked this pull request as ready for review June 25, 2024 07:33
Copy link

sonarcloud bot commented Jun 25, 2024

@hexoscott
Copy link
Collaborator Author

@mandrigin - I've tidied some bits up now and actioned the change in function name. How does it look now?

@mandrigin mandrigin merged commit 34f782c into zkevm Jun 25, 2024
5 checks passed
@mandrigin mandrigin deleted the witness-for-invalid-batch branch June 25, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants