Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change balance and nonce in zero's tracer output from decimal to hex #1350

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Change balance and nonce in zero's tracer output from decimal to hex #1350

merged 2 commits into from
Oct 25, 2024

Conversation

cffls
Copy link

@cffls cffls commented Oct 22, 2024

This should address the issue in #1110 (comment)

@cla-bot cla-bot bot added the cla-signed label Oct 22, 2024
Stefan-Ethernal
Stefan-Ethernal reviewed Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check:
we do not need to provide the unmarshaling logic, because the traces are consumed by external parties and we are not expecting that traces are going to be ever imported/loaded into the CDK Erigon from the outside?

core/types/trace.go Show resolved Hide resolved
core/types/trace.go Show resolved Hide resolved
core/types/trace.go Show resolved Hide resolved
Stefan-Ethernal
Stefan-Ethernal approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from proposed change.

@cffls cffls merged commit 6ff23b3 into zkevm Oct 25, 2024
14 checks passed
@cffls cffls deleted the fix/zero_tracer_hex branch October 25, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cffls @Stefan-Ethernal