Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add conditional progress printer on smt_batch so we don't spam on sta… #1122

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

V-Staykov
Copy link
Collaborator

…ge_execute

@cla-bot cla-bot bot added the cla-signed label Sep 5, 2024
Copy link
Collaborator

@hexoscott hexoscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small suggestion but looks good to me

smt/pkg/blockinfo/block_info.go Outdated Show resolved Hide resolved
revitteth
revitteth previously approved these changes Sep 5, 2024
Copy link

sonarcloud bot commented Sep 9, 2024

@V-Staykov V-Staykov merged commit f859d36 into zkevm Sep 9, 2024
11 checks passed
@V-Staykov V-Staykov deleted the conditional-progress-printer-smt_batch branch September 9, 2024 08:51
Stefan-Ethernal pushed a commit that referenced this pull request Sep 20, 2024
#1122)

* add conditional progress printer on smt_batch so we don't spam on stage_execute

* contructor for the insertBatchConfig

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants