Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zkevm api unit test #1076

Merged
merged 11 commits into from
Sep 4, 2024
Merged

zkevm api unit test #1076

merged 11 commits into from
Sep 4, 2024

Conversation

ARR552
Copy link

@ARR552 ARR552 commented Aug 30, 2024

It adds the next unit tests for zkevm api:

  • TestLatestConsolidatedBlockNumber
  • TestIsBlockConsolidated
  • TestIsBlockVirtualized
  • TestBatchNumberByBlockNumber
  • TestBatchNumber
  • TestVirtualBatchNumber
  • TestVerifiedBatchNumber

@cla-bot cla-bot bot added the cla-signed label Aug 30, 2024
@ARR552 ARR552 force-pushed the test/zkevm_api_unit_test branch 3 times, most recently from cc22e0d to 46389ad Compare August 30, 2024 21:07
Copy link

sonarcloud bot commented Sep 1, 2024

Copy link
Collaborator

@mandrigin mandrigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mandrigin mandrigin merged commit f911a0d into zkevm Sep 4, 2024
10 checks passed
@mandrigin mandrigin deleted the test/zkevm_api_unit_test branch September 4, 2024 12:17
Stefan-Ethernal pushed a commit that referenced this pull request Sep 20, 2024
* TestLatestConsolidatedBlockNumber, TestIsBlockConsolidated + fix

* TestIsBlockVirtualized

* TestBatchNumberByBlockNumber

* TestBatchNumber

* TestVirtualBatchNumber

* TestVerifiedBatchNumber

* Remove test comments

This reverts commit 8ec56a7.

* error lint

* Fix extra test

* fix kurtosis test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants