Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if forkid8 is on #1048

Conversation

V-Staykov
Copy link
Collaborator

No description provided.

V-Staykov and others added 2 commits August 28, 2024 14:16
…eipt-response-is-different-between-zkevm-client-and-cdk-erigon-client-for-some-chain
@V-Staykov V-Staykov enabled auto-merge (squash) August 28, 2024 15:17
Copy link

sonarcloud bot commented Aug 28, 2024

@V-Staykov V-Staykov merged commit 20c92c3 into zkevm Aug 29, 2024
10 checks passed
@V-Staykov V-Staykov deleted the 1007-gasused-value-in-eth_gettransactionreceipt-response-is-different-between-zkevm-client-and-cdk-erigon-client-for-some-chain branch August 29, 2024 10:49
@akramhussein
Copy link

@V-Staykov @kstoykov do you happen to know when a release will be cut with this fix? Thanks

@kstoykov
Copy link
Collaborator

kstoykov commented Sep 4, 2024

I'm tagging @hexoscott and @mandrigin . They could now better than me when this will be included in a version.

@akramhussein
Copy link

@hexoscott @mandrigin gentle bump - do you know when this PR will be part of a release?

@hexoscott
Copy link
Collaborator

Hi @akramhussein - I'm not certain on the timescales for this sorry

Stefan-Ethernal pushed a commit that referenced this pull request Sep 20, 2024
* check if forkid8 is on

* fix test
@akramhussein
Copy link

Hi @hexoscott - there was a release today v1.2.18 - a large jump from 1.2.15.7 with no intermediate releases.

From the changelog and reviewing the code it doesn't look like this PR #1048 was part of the release.

Do you have any notes/advice on how releases are cut so we can better understand the process and plan accordingly?

There is a persistent bug in the response that make it not possible to correctly index data.

@hexoscott
Copy link
Collaborator

Hi @akramhussein,

Some info on the release numbers:
v1.1.x - first cdk-erigon releases suitable for RPC only
v.1.2.x - first releases suitable for the sequencer. Recently the .X part has tied in to a beta, so the 1.2.18 release ties to the beta 18 stable feature set, .19 will tie to beta19 and so on. We created 1.2.18 last week to solidify the stable feature set from beta 18 and make it the official latest version of cdk-erigon. An RPC node running this version can sync Bali and Cardona without issue.
v2.x - will be the first official releases supporting mainnet zkevm

I'll see if we can get this PR into the RC1 branch.

hexoscott pushed a commit that referenced this pull request Sep 23, 2024
* check if forkid8 is on

* fix test
@hexoscott
Copy link
Collaborator

An update on this @akramhussein - this PR is now in the RC1 branch which is the candidate for the next major release

@hexoscott
Copy link
Collaborator

There is also an image of this currently building here https://github.com/0xPolygonHermez/cdk-erigon/actions/runs/10991447990

hexoscott pushed a commit that referenced this pull request Sep 25, 2024
* check if forkid8 is on

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants