print empty batchl2data and custom batch 0 cases for getBatchByNumber #1031
Conversation
There was a problem hiding this comment.
Looks fine, but I'm worried about new things being added around GERs in the batch data. We've had a lot of fighting with zkevm_getBatchByNumber having exit root problems which are now stable. I think we'll want to test these changes in some network that has a legacy node syncing from erigon RPC to verify these changes are OK.
|
zkevm_getBatchByNumber is still not matching legacy for a lot of stuff. The GER's are not completely fixed but they were wrong before anyways. We are kind of blocked right now, because on legacy there seems to be some strange behavios around printing GERs on batches where it wasn't changed. |
|
@revitteth - would be ace if you can weigh in on this one as you're more familiar with the exit root stuff |
Yeah, looks good to me! |
…g-wrong-fields-for-batches-0-and-1
…g-wrong-fields-for-batches-0-and-1
…g-wrong-fields-for-batches-0-and-1
|
V-Staykov
deleted the
1021-rpc-zkevm_getbatchbynumber-is-returning-wrong-fields-for-batches-0-and-1
branch
…0xPolygonHermez#1031) * print empty batchl2data and custom batch 0 cases for getBatchByNumber * add changeblocktx data to batchl2data only after forkid7 * add block not found for batch query * ger writing fix for getBatchByNumber * remove missing method from interfaces
…#1031) * print empty batchl2data and custom batch 0 cases for getBatchByNumber * add changeblocktx data to batchl2data only after forkid7 * add block not found for batch query * ger writing fix for getBatchByNumber * remove missing method from interfaces
No description provided.