Skip to content

Commit

Permalink
defer rollback on datastream (#864)
Browse files Browse the repository at this point in the history
  • Loading branch information
V-Staykov authored Jul 29, 2024
1 parent e6ad94f commit 463d005
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions zk/datastream/server/datastream_populate.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ func (srv *DataStreamServer) WriteWholeBatchToStream(
if err = srv.stream.StartAtomicOp(); err != nil {
return err
}
defer srv.stream.RollbackAtomicOp()

blocksForBatch, err := reader.GetL2BlockNosByBatch(batchNum)
if err != nil {
Expand Down Expand Up @@ -118,6 +119,7 @@ func (srv *DataStreamServer) WriteBlocksToStreamConsecutively(
if err = srv.stream.StartAtomicOp(); err != nil {
return err
}
defer srv.stream.RollbackAtomicOp()

if err = srv.UnwindIfNecessary(logPrefix, reader, from, latestbatchNum, batchNum); err != nil {
return err
Expand Down Expand Up @@ -221,6 +223,7 @@ func (srv *DataStreamServer) WriteBlockWithBatchStartToStream(
if err = srv.stream.StartAtomicOp(); err != nil {
return err
}
defer srv.stream.RollbackAtomicOp()

blockNum := block.NumberU64()

Expand Down Expand Up @@ -327,6 +330,7 @@ func (srv *DataStreamServer) WriteBatchEnd(
if err = srv.stream.StartAtomicOp(); err != nil {
return err
}
defer srv.stream.RollbackAtomicOp()

batchEndEntries, err := addBatchEndEntriesProto(batchNumber, stateRoot, gers, localExitRoot)
if err != nil {
Expand Down Expand Up @@ -363,6 +367,7 @@ func (srv *DataStreamServer) WriteGenesisToStream(
if err != nil {
return err
}
defer srv.stream.RollbackAtomicOp()

batchBookmark := newBatchBookmarkEntryProto(genesis.NumberU64())
l2BlockBookmark := newL2BlockBookmarkEntryProto(genesis.NumberU64())
Expand Down

0 comments on commit 463d005

Please sign in to comment.