remove sendall opcode and use it on selfdestruct only (#1056)

0xPolygonHermez · Aug 28, 2024 · 423754c · 423754c
1 parent 79f49f3
commit 423754c
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 17 deletions.
diff --git a/core/vm/eips_zkevm.go b/core/vm/eips_zkevm.go
@@ -44,7 +44,6 @@ func enable2929_zkevm(jt *JumpTable) {
 	// factor here
 	jt[SELFDESTRUCT].constantGas = params.SelfdestructGasEIP150
 	jt[SELFDESTRUCT].dynamicGas = gasSelfdestructEIP2929_zkevm
-	jt[SENDALL].dynamicGas = gasSelfdestructEIP2929_zkevm
 }
 
 func enable3529_zkevm(jt *JumpTable) {

diff --git a/core/vm/interpreter_zkevm.go b/core/vm/interpreter_zkevm.go
@@ -66,8 +66,6 @@ func shouldExecuteLastOpCode(op OpCode) bool {
 		fallthrough
 	case CREATE2:
 		fallthrough
-	case SENDALL:
-		fallthrough
 	case SLOAD:
 		fallthrough
 	case SSTORE:

diff --git a/core/vm/jump_table_zkevm.go b/core/vm/jump_table_zkevm.go
@@ -38,15 +38,8 @@ func newForkID4InstructionSet() JumpTable {
 
 	instructionSet[EXTCODEHASH].execute = opExtCodeHash_zkevm
 
-	instructionSet[SENDALL] = &operation{
-		execute:    opSendAll_zkevm,
-		dynamicGas: gasSelfdestruct_zkevm,
-		numPop:     1,
-		numPush:    0,
-	}
-
 	// SELFDESTRUCT is replaces by SENDALL
-	instructionSet[SELFDESTRUCT] = instructionSet[SENDALL]
+	instructionSet[SELFDESTRUCT].execute = opSendAll_zkevm
 
 	validateAndFillMaxStack(&instructionSet)
 	return instructionSet

diff --git a/core/vm/opcodes_zkevm.go b/core/vm/opcodes_zkevm.go
@@ -1,12 +1,9 @@
 package vm
 
-const (
-	SENDALL OpCode = 0xfb
-)
+const ()
 
 // adding extra opcodes dynamically to keep separate from the main codebase
 // that simplifies rebasing new versions of Erigon
 func init() {
-	opCodeToString[SENDALL] = "SENDALL"
-	stringToOp["SENDALL"] = SENDALL
+
 }
diff --git a/core/vm/zk_counters.go b/core/vm/zk_counters.go
@@ -347,7 +347,6 @@ func SimpleCounterOperations(cc *CounterCollector) *[256]executionFunc {
 		CREATE2:        cc.opCreate2,
 		RETURN:         cc.opReturn,
 		REVERT:         cc.opRevert,
-		SENDALL:        cc.opSendAll,
 		SELFDESTRUCT:   cc.opSendAll,
 		INVALID:        cc.opInvalid,
 		ADDRESS:        cc.opAddress,