This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brkomir
approved these changes
Dec 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks ok! Fix the linter errors and we are good to go
Kourin1996
suggested changes
Dec 28, 2021
Kourin1996
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
lazartravica
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flawless, great job.
Good thinking about the helper methods for bootstrapping the network.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the tests in the networking package, fixes bugs and adds new coverage tests.
Additionally, this PR resolves all pending linting errors (3937fbc) and modifies the GH Actions workflow file for the linter (886c4d5)
Encountered issues:
Failed linting
Currently, the linting checks fail on GH actions because some structures are unused due to test skips.
This PR should wait for #312, which contains the libp2p package updates before unskipping the tests and fixing linting errors that arise from this.
Changes include
Checklist
Additional comments
Due to a known and fixed libp2p bug (libp2p/go-libp2p#1090), some test have been skipped for now:
TestSimpleGossip
TestSyncer_PeerDisconnected
The Polygon SDK is running version
v0.12.0
of libp2p, where this issue is still present.These tests will be un-skipped as soon as #312 is merged (after the libp2p package is updated to
v0.14.0
EDIT: Tests un-skipped ✅