Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): check generated files should be reliable #195

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

leovct
Copy link
Member

@leovct leovct commented Jan 26, 2024

Use a specific solc version when generating files to make sure a new solc release doesn't break our CI job.
See #192 (comment)

We'll migrate to solc 0.8.24 once forge supports it: foundry-rs/foundry#6903

@leovct leovct requested a review from a team January 26, 2024 17:47
@leovct leovct marked this pull request as ready for review January 26, 2024 17:47
@gatsbyz gatsbyz merged commit eafc0bb into main Jan 26, 2024
6 checks passed
@gatsbyz gatsbyz deleted the fix/ci-check-generated-files branch January 26, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants