forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting: gov module #7
Merged
Merged
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
20c7bab
add: port gov module
Raneet10 5fabe14
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 6ae10dc
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 2529319
chg: implement WeightedVoteOptions with constraints
marcello33 e1a6c2f
chg: better TODOs descriptions
marcello33 246fce5
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 f159c6d
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 ae5a857
chg: POS-2135: fix some tests
marcello33 8d85eb1
chg: POS-2135: fix more tests
marcello33 0dc2578
chg: POS-2135: update an address format
marcello33 f53183e
chg: fix few more tests
marcello33 705b5e8
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 4010477
chg: fix few more tests
marcello33 1b93e32
chg: fix some tests / temp revert some others to properly tune params…
marcello33 ae2226d
chg: fix TestHooks
marcello33 ae826fb
chg: fix burn related methods / fix tests
marcello33 36d79e4
chg: fix query for WeightedVoteOptions / better comments
marcello33 8ea74f0
chg: fix all tests in gov module
marcello33 89cac52
chg: fix a staking integration test
marcello33 c92a5e0
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 e85fe55
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 c793367
chg: POS-2142: edit gov readme
marcello33 d4fc81d
chg: use AccAddressFromHex in tests instead of addressCodec
marcello33 28f9940
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 756fcf2
chg: enable one test / provide better context for the only skipped test
marcello33 9b9609a
chg: use hex acc addresses in gov tests
marcello33 ba0eac3
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 2031f34
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 3ecf8d5
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 069cbf0
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 f00a504
chg: return empty string on ProposalType normalization
marcello33 d6ffea2
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 d22489d
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 7ca5b40
chg: remove TextProposals / add comment for Msgs auto-execution
marcello33 3b03e87
chg: re-enable textProposals / TBD with team
marcello33 8a1af2d
chg: remove comment
marcello33 90360da
chg: better context for HV2 TODOs
marcello33 4abf435
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 13af779
chg: filter out non valid proposals msgs types and content
marcello33 e2011fb
chg: fix typeUrls
marcello33 f126f22
chg: filter out not supported messages at time of proposals submit / …
marcello33 72ea82b
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 9f8955c
chg: go mod tidy
marcello33 39fd8a9
chg: address PR comments: filtering dedicated file / test msg types /…
marcello33 0223595
chg: register interfaces in gov test app
marcello33 21f52a1
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 a3097b1
chg: better context for comments
marcello33 efc6cf5
chg: comment for future improvements
marcello33 3f551ab
chg: consistent example of gov tx for submit proposal
marcello33 ec29c6e
chg: add msgServers in testApp to allow additional MsgUpdateParams types
marcello33 f72216e
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 268611f
chg: fix tests after merge
marcello33 942d844
chg: update go deps for sdk and simapp
marcello33 39dd6b9
Merge branch 'mardizzone/POS-1956-auth' into mardizzone/POS-2129-gov
marcello33 1d959cc
chg: comment
marcello33 e2147a2
chg: comment in README for further actions
marcello33 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if weighted voting is not supported in Heimdall, would it nevertheless be simpler to leave this as
NewCmdWeightedVote
so that we spend less time re-doing the tests? (at the end of the day, this is test code)Or are you planning on testing something else than what is tested in vanilla SDK
v0.50.x
?This would also apply to file
x/feegrant/client/cli/tx_test.go
below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I agree. Changed it in the very beginning with the purpose of implementing some tests, but both are actually covered in the vanilla SDK. Reverted here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved