-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: postgres vector store #231
feat: postgres vector store #231
Conversation
@0xMochan @cvauclair do you mind taking a look into this? |
13857d9
to
a3caabb
Compare
Hey @carlos-verdes just saw your ping, wasn't sure if the PR was ready for review since it's still a draft but I'll take a look later today! Thanks a lot for the PR, let's get this |
It's in draft because documentation is not finished, but the code + example + integration test is ready. I can add later an example using Streams if that would be useful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid! I added a couple suggestions/comments, please take a look when you have a moment.
Cheers!
@cvauclair thanks for the review, I updated code based on your comments, take a look and let me know if you want to squash the commits. |
ff87b41
to
0450fe4
Compare
0450fe4
to
ca8c3aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks for the contribution @carlos-verdes !
Resolves #5 based on PR #157
@milancermak mentioned not having time to finish his PR so I created this one based on his implementation.
Current code has just the library code but I added an integration test based on rig-qdrant module, it starts a Docker container with Postgres + PgVector and it simulate calls to OpenAI using a mocked API.
Difference from previous PR:
Serializable
,Deserializable
make run
(from rig-postgres folder), load environmental variables from.env
file and handles documents with more than one embedding. It also runs migrations automatically on the database to make sure Postgres tables are ready for the test.Pending: