refactor: Use package local metrics #1605
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
local_metrics_2
branch
2 times, most recently
from
9d1d131
to
54b3271
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1605 +/- ##
==========================================
- Coverage 93.88% 93.85% -0.04%
==========================================
Files 78 80 +2
Lines 6361 6574 +213
==========================================
+ Hits 5972 6170 +198
- Misses 300 320 +20
+ Partials 89 84 -5 ☔ View full report in Codecov by Sentry. |
|
I'm working on an improvement to the tests using the client_golang testutil. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Not really stale, but I haven't had a chance to work on the coverage change. |
Part 2 (0xERR0R#1578) Improve performance of metrics by moving them to the package that needs them. This reduces the overhead to a simple atomic increment for basic counters like cache hits/misses. This also uses `promauto` to avoid the second step of having to register metrics. Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
local_metrics_2
branch
from
54b3271
to
823c916
Compare
|
@0xERR0R, how do you feel about the coverage change here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 (#1578)
Improve performance of metrics by moving them to the package that needs them. This reduces the overhead to a simple atomic increment for basic counters like cache hits/misses. This also uses
promautoto avoid the second step of having to register metrics.