Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): Remove cross-origin redirect proxy support #477

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

0x676e67
Copy link
Owner

This pull request involves the removal of the redirect_with_proxy_auth feature from the HTTP client in the src/client/http.rs file. The changes simplify the codebase by removing associated configurations, methods, and references to this feature.

Key changes include:

Removal of redirect_with_proxy_auth feature:

  • src/client/http.rs: Removed the redirect_with_proxy_auth field from the Config and ClientInner structs. [1] [2]
  • src/client/http.rs: Deleted the redirect_with_proxy_auth method from the ClientBuilder implementation.
  • src/client/http.rs: Removed references to redirect_with_proxy_auth from the ClientBuilder and PendingRequest implementations. [1] [2] [3]

Update to header removal logic:

  • src/redirect.rs: Simplified the remove_sensitive_headers method by removing the cross_proxy_auth parameter and its associated logic.

Tests update:

  • src/redirect.rs: Updated the test_remove_sensitive_headers test to reflect the changes in the remove_sensitive_headers method and removed the test_proxy_auth_redirect_headers test.

@0x676e67 0x676e67 changed the title feat(client): Remove cross- origin redirect proxy support feat(client): Remove cross-origin redirect proxy support Feb 24, 2025
@0x676e67 0x676e67 merged commit 3a241ef into v3 Feb 24, 2025
6 checks passed
@0x676e67 0x676e67 deleted the feat branch February 24, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant