Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Apple platform dependencies are minimized as much as possible #414

Merged
merged 4 commits into from
Feb 8, 2025

Conversation

0x676e67
Copy link
Owner

@0x676e67 0x676e67 commented Feb 8, 2025

This pull request introduces a new feature for supporting Apple platform's network device binding and includes several related changes across multiple files. The most important changes are listed below:

Dependency Management:

  • Added apple-bindable-device dependency to Cargo.toml to enable the new feature for Apple platforms.
  • Made the libc dependency optional for Apple platforms in Cargo.toml.

Feature Configuration:

  • Updated the required-features for the client_chain example to include the new apple-bindable-device feature in Cargo.toml.

Code Modifications:

  • Changed the network interface from "utun4" to "utun6" in the client_chain.rs example to reflect the new feature.
  • Updated the cfg_bindable_device and cfg_non_bindable_device macros in src/lib.rs to conditionally include the new feature for Apple platforms. [1] [2]
  • Modified the connect function in src/util/client/connect/http.rs to support the new feature for Apple platforms.

@0x676e67 0x676e67 merged commit 858d911 into main Feb 8, 2025
4 checks passed
@0x676e67 0x676e67 deleted the build branch February 8, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant