Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): macOS platform dependencies are minimized as much as possible #413

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

0x676e67
Copy link
Owner

@0x676e67 0x676e67 commented Feb 8, 2025

This pull request introduces several changes to add support for macOS system configuration as an optional feature. The most important changes include modifications to the Cargo.toml file to define the new feature and updates to the src/proxy.rs file to conditionally compile code based on the feature flag.

Feature addition in Cargo.toml:

  • Added macos-system-configuration to the default features list.
  • Defined the macos-system-configuration feature to use the system-configuration dependency.
  • Marked the system-configuration dependency as optional for macOS targets.

Conditional compilation in src/proxy.rs:

  • Updated the import statement for system_configuration to be conditional on the macos-system-configuration feature.
  • Modified the parse_setting_from_dynamic_store and get_from_platform_impl functions to conditionally compile based on the macos-system-configuration feature. [1] [2]
  • Adjusted the get_from_platform function to include the feature flag in its conditional compilation.

@0x676e67 0x676e67 merged commit f85c7ee into main Feb 8, 2025
4 checks passed
@0x676e67 0x676e67 deleted the build branch February 8, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant