feat: Removal of base url feature #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering this feature is pretty useless and most rust http clients don't need it
This pull request removes the
base_urlfeature from therquestlibrary. The changes involve eliminating thebase_urlfield from various structs and methods, as well as updating the examples and documentation accordingly.Key changes include:
Removal of
base_urlfeature:Cargo.toml: Removed thebase_urlexample entry.examples/base_url.rs: Deleted the entire file as it was specific to thebase_urlfeature.src/client/http.rs: Removed thebase_urlfield fromConfig,ClientBuilder, andClientInnerstructs, and deleted associated methods and debug implementations. [1] [2] [3] [4] [5] [6] [7] [8] [9]examples/client_chain.rs: Removed the usage ofbase_urlin the example.