Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): rename client builder http2 timer name from timer to http2_timer #407

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

0x676e67
Copy link
Owner

@0x676e67 0x676e67 commented Feb 8, 2025

This pull request includes changes to improve the naming consistency for HTTP/2 timer methods and documentation in the src/client/http.rs and src/util/client/mod.rs files. The most important changes include renaming the timer method and updating related documentation references.

Improvements to naming consistency:

  • src/client/http.rs: Renamed the timer method to http2_timer to reflect its purpose more clearly.
  • src/util/client/mod.rs: Updated the method name from timer to http2_timer and modified the associated documentation to use http2 instead of h2, ensuring consistency with the new naming convention.

@0x676e67 0x676e67 changed the title chore(client): rename client builder http2 timer chore(client): rename client builder http2 timer name from timer to http2_timer Feb 8, 2025
@0x676e67 0x676e67 merged commit e06d9ce into main Feb 8, 2025
4 checks passed
@0x676e67 0x676e67 deleted the chore branch February 8, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant