perf(connector): Optimize performance of switching TLS connector #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
src/connect.rs
andsrc/client/http.rs
files, focusing on simplifying theConnectorBuilder
andConnector
implementations, removing unused imports, and refactoring the handling of TLS connectors.Refactoring and simplification:
src/client/http.rs
: Simplified theConnectorBuilder
construction by chaining method calls instead of using intermediate variables.src/connect.rs
: Refactored theConnectorBuilder
methods (set_keepalive
,set_timeout
,set_verbose
) to returnself
for method chaining.src/connect.rs
: Removed theInnerTLS
enum and replaced it with a simpler direct use ofBoringTlsConnector
.Code cleanup:
src/connect.rs
: Removed unused imports (antidote::RwLock
andstd::sync::Arc
). [1] [2]Improved
Connector
handling:src/connect.rs
: Updated theConnector::WithLayers
variant to includelayers
andbase_service
, and refactored theset_connector
method to rebuild the connector with the new TLS settings. [1] [2] [3]