Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace unsafe methods with safe methods for certificate handler #399

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

0x676e67
Copy link
Owner

@0x676e67 0x676e67 commented Feb 7, 2025

This pull request includes several changes to improve the handling of certificate compression and update dependencies. The most important changes include updating the boring2 dependency, removing the cert/compression.rs module, and refactoring related code.

Dependency updates:

  • Updated boring2 to version 4.15.2 and added the cert-compression feature. Removed boring-sys2 dependency. (Cargo.toml)

Code refactoring:

  • Removed the cert/compression.rs module, along with the CertCompressionAlgorithm enum and related functions. (src/tls/cert/compression.rs)
  • Refactored imports and usage of CertCompressionAlgorithm in various modules to align with the removal of cert/compression.rs. (src/imp/mod.rs, src/lib.rs, src/tls/ext.rs, src/tls/mod.rs) [1] [2] [3] [4]

Simplification of certificate store handling:

  • Replaced direct usage of ffi functions with higher-level methods from the boring2 crate for setting certificate stores. (src/tls/cert/mod.rs) [1] [2]…ndler

@0x676e67 0x676e67 merged commit bdf1fc5 into main Feb 7, 2025
4 checks passed
@0x676e67 0x676e67 deleted the ref branch February 7, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant