Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to v0.47.10 #7

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

Solovyov1796
Copy link
Collaborator

@Solovyov1796 Solovyov1796 commented Jul 31, 2024

This change is Reviewable

server/util.go Dismissed Show dismissed Hide dismissed
server/util.go Dismissed Show dismissed Hide dismissed
server/util.go Dismissed Show dismissed Hide dismissed
x/mint/abci.go Dismissed Show dismissed Hide dismissed
x/mint/abci.go Dismissed Show dismissed Hide dismissed
Copy link
Collaborator Author

@Solovyov1796 Solovyov1796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 104 files reviewed, 5 unresolved discussions (waiting on @0g-wh, @Github-advanced-security[bot], and @zeroxsatoshi)


server/util.go line 224 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

Calling the system time

Calling the system time may be a possible source of non-determinism

Show more details

Done.


server/util.go line 226 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

Calling the system time

Calling the system time may be a possible source of non-determinism

Show more details

Done.


server/util.go line 228 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

Errors unhandled.

Errors unhandled.

Show more details

Done.


x/mint/abci.go line 62 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

Panic in BeginBock or EndBlock consensus methods

path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call

Show more details

Done.


x/mint/abci.go line 63 at r1 (raw file):

Previously, github-advanced-security[bot] wrote…

Panic in BeginBock or EndBlock consensus methods

path flow from Begin/EndBlock to a panic call

Show more details

Done.

Copy link
Collaborator

@zeroxsatoshi zeroxsatoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 104 of 104 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @0g-wh and @Github-advanced-security[bot])

@Solovyov1796 Solovyov1796 merged commit d3e218e into 0glabs-v0.47.10-release-x Aug 1, 2024
10 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants