Skip to content

Commit

Permalink
mm-memcg-use-consistent-gfp-flags-during-readahead-checkpatch-fixes
Browse files Browse the repository at this point in the history
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
torvalds#155: FILE: mm/readahead.c:111:
+		struct list_head *pages, unsigned nr_pages, gfp_t gfp_mask)

WARNING: line over 80 characters
torvalds#165: FILE: mm/readahead.c:129:
+		if (!add_to_page_cache_lru(page, mapping, page->index, gfp_mask)) {

WARNING: braces {} are not necessary for single statement blocks
torvalds#165: FILE: mm/readahead.c:129:
+		if (!add_to_page_cache_lru(page, mapping, page->index, gfp_mask)) {
 			mapping->a_ops->readpage(filp, page);
 		}

total: 0 errors, 3 warnings, 111 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/mm-memcg-use-consistent-gfp-flags-during-readahead.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Michal Hocko <mhocko@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 authored and sfrothwell committed Jun 15, 2016
1 parent 014aaff commit aa6a820
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions mm/readahead.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ int read_cache_pages(struct address_space *mapping, struct list_head *pages,
EXPORT_SYMBOL(read_cache_pages);

static int read_pages(struct address_space *mapping, struct file *filp,
struct list_head *pages, unsigned nr_pages, gfp_t gfp_mask)
struct list_head *pages, unsigned int nr_pages, gfp_t gfp)
{
struct blk_plug plug;
unsigned page_idx;
Expand All @@ -126,9 +126,8 @@ static int read_pages(struct address_space *mapping, struct file *filp,
for (page_idx = 0; page_idx < nr_pages; page_idx++) {
struct page *page = lru_to_page(pages);
list_del(&page->lru);
if (!add_to_page_cache_lru(page, mapping, page->index, gfp_mask)) {
if (!add_to_page_cache_lru(page, mapping, page->index, gfp))
mapping->a_ops->readpage(filp, page);
}
put_page(page);
}
ret = 0;
Expand Down

0 comments on commit aa6a820

Please sign in to comment.