Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit endpoint to get files metadata by keyword search #962

Conversation

din-mukhammed
Copy link
Contributor

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@din-mukhammed din-mukhammed linked an issue Feb 25, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Merging #962 (df29533) into staging (0b59e49) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging     #962      +/-   ##
===========================================
- Coverage    26.18%   25.98%   -0.21%     
===========================================
  Files           76       76              
  Lines         7744     7806      +62     
===========================================
  Hits          2028     2028              
- Misses        5444     5506      +62     
  Partials       272      272              
Flag Coverage Δ
Unit-Tests 25.98% <0.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
code/go/0chain.net/blobbercore/handler/handler.go 61.71% <0.00%> (-0.79%) ⬇️
.../0chain.net/blobbercore/handler/storage_handler.go 21.81% <0.00%> (-1.47%) ⬇️
code/go/0chain.net/blobbercore/reference/ref.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@din-mukhammed din-mukhammed changed the title [WIP] Add endpoint to get files metadata by keyword search Add endpoint to get files metadata by keyword search Feb 26, 2023
@din-mukhammed din-mukhammed changed the title Add endpoint to get files metadata by keyword search Edit endpoint to get files metadata by keyword search Feb 26, 2023
@din-mukhammed din-mukhammed marked this pull request as ready for review February 26, 2023 08:37
@din-mukhammed din-mukhammed marked this pull request as draft March 4, 2023 20:14
@din-mukhammed din-mukhammed marked this pull request as ready for review March 5, 2023 17:43
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 2f30e10 into staging Mar 7, 2023
@din-mukhammed din-mukhammed deleted the 820-search-endpoint-to-get-file-detailsmetadata-using-lookuphash branch May 29, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search endpoint to get file details/metadata using lookupHash
3 participants