Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use correct configuration file on validator conductor container #932

Merged
merged 1 commit into from
Feb 1, 2023
Merged

use correct configuration file on validator conductor container #932

merged 1 commit into from
Feb 1, 2023

Conversation

fabioDMFerreira
Copy link
Contributor

Fixes

Change dockerfile of validator conductor image to use the right workspace directory.

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

cnlangzi
cnlangzi approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit 21f8651 into staging Feb 1, 2023
@cnlangzi cnlangzi deleted the fix/validator-conductor-dockerfile branch February 1, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnlangzi cnlangzi cnlangzi approved these changes

@guruhubb guruhubb guruhubb approved these changes

@shahnawaz-creator shahnawaz-creator shahnawaz-creator approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@dabasov dabasov Awaiting requested review from dabasov dabasov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabioDMFerreira @cnlangzi @guruhubb @shahnawaz-creator