Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(writepreredeem): improved error handler #903

Merged

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Jan 2, 2023

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Merging #903 (003d30b) into staging (d78617d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           staging     #903      +/-   ##
===========================================
- Coverage    26.43%   26.41%   -0.03%     
===========================================
  Files           77       77              
  Lines         7875     7883       +8     
===========================================
  Hits          2082     2082              
- Misses        5521     5529       +8     
  Partials       272      272              
Flag Coverage Δ
Unit-Tests 26.41% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ode/go/0chain.net/blobbercore/allocation/entity.go 0.00% <0.00%> (ø)
...et/blobbercore/handler/object_operation_handler.go 31.29% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@boddumanohar boddumanohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@cnlangzi cnlangzi merged commit 924703b into staging Jan 4, 2023
@cnlangzi cnlangzi deleted the fix/improve_error_handle_on_get_write_pools_balance branch January 4, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants