Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for Challenge Timing Details #833

Merged
merged 7 commits into from
Oct 8, 2022
Merged

API for Challenge Timing Details #833

merged 7 commits into from
Oct 8, 2022

Conversation

avanaur
Copy link
Contributor

@avanaur avanaur commented Sep 19, 2022

Changes

Add API to serve the challenge timings history.
This will be used for chart visualisation during load test and potentially on blobber page as a table

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #833 (f277e3b) into staging (02f3d99) will decrease coverage by 0.14%.
The diff coverage is 1.88%.

@@             Coverage Diff             @@
##           staging     #833      +/-   ##
===========================================
- Coverage    24.28%   24.13%   -0.15%     
===========================================
  Files           80       82       +2     
  Lines         8108     8161      +53     
===========================================
+ Hits          1969     1970       +1     
- Misses        5861     5913      +52     
  Partials       278      278              
Flag Coverage Δ
Unit-Tests 24.13% <1.88%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chain.net/blobbercore/handler/challenge_timings.go 0.00% <0.00%> (ø)
code/go/0chain.net/core/common/pagination.go 0.00% <0.00%> (ø)
code/go/0chain.net/blobbercore/handler/handler.go 56.80% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@avanaur avanaur changed the title WIP Challenge Timings API for Challenge Timing Details Oct 2, 2022
@avanaur avanaur marked this pull request as ready for review October 2, 2022 12:47
@cnlangzi cnlangzi merged commit b9a7bc7 into staging Oct 8, 2022
@cnlangzi cnlangzi deleted the challenge-timings branch October 8, 2022 06:33
@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants