Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add malicious blobber behaviours #803

Merged
merged 12 commits into from
Oct 26, 2022
Merged

Conversation

fabioDMFerreira
Copy link
Contributor

@fabioDMFerreira fabioDMFerreira commented Aug 17, 2022

Malicious blobber:

  • sends wrong data on listing
  • sends wrong metadata on listing
  • does not respond on listing/deleting/uploading/downloading
  • returns an error on listing/deleting/uploading/downloading

@fabioDMFerreira fabioDMFerreira force-pushed the add-send-wrong-bad-data-behaviour branch from 3d62e06 to b511459 Compare August 17, 2022 15:22
@fabioDMFerreira fabioDMFerreira changed the title Add malicious blobber behaviour that sends wrong data on listing Add malicious blobber behaviours Aug 18, 2022
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -0,0 +1,13 @@
//go:build integration_tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this file is the same as handler_main.gp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. This is part of validator conductor tests development. We'll need to override the endpoint handler /v1/storage/challenge/new.

@codecov-commenter
Copy link

Codecov Report

Merging #803 (6cddf68) into staging (1ce9f4a) will increase coverage by 0.03%.
The diff coverage is 18.05%.

@@             Coverage Diff             @@
##           staging     #803      +/-   ##
===========================================
+ Coverage    24.28%   24.32%   +0.03%     
===========================================
  Files           80       85       +5     
  Lines         8095     8141      +46     
===========================================
+ Hits          1966     1980      +14     
- Misses        5854     5886      +32     
  Partials       275      275              
Flag Coverage Δ
Unit-Tests 24.32% <18.05%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../go/0chain.net/blobbercore/handler/grpc_handler.go 8.69% <ø> (+0.95%) ⬆️
...chain.net/blobbercore/handler/grpc_handler_main.go 0.00% <0.00%> (ø)
...obbercore/handler/object_operation_grpc_handler.go 0.00% <ø> (ø)
...core/handler/object_operation_grpc_handler_main.go 0.00% <0.00%> (ø)
code/go/0chain.net/core/common/handler.go 0.00% <0.00%> (ø)
...ode/go/0chain.net/validatorcore/storage/handler.go 0.00% <0.00%> (ø)
...o/0chain.net/validatorcore/storage/handler_main.go 0.00% <0.00%> (ø)
...ain.net/validatorcore/storage/challenge_handler.go 29.41% <16.66%> (-1.08%) ⬇️
...ode/go/0chain.net/blobbercore/handler/b_handler.go 56.38% <80.00%> (ø)
...o/0chain.net/blobbercore/handler/b_handler_main.go 83.33% <83.33%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fabioDMFerreira fabioDMFerreira force-pushed the add-send-wrong-bad-data-behaviour branch 2 times, most recently from 850d8b5 to 8cb0a89 Compare October 10, 2022 08:47
@fabioDMFerreira fabioDMFerreira force-pushed the add-send-wrong-bad-data-behaviour branch 4 times, most recently from cace4f3 to def1306 Compare October 20, 2022 16:29
@cnlangzi cnlangzi deleted the add-send-wrong-bad-data-behaviour branch January 29, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants