Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blobber compilation for conductor tests #735

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

fabioDMFerreira
Copy link
Contributor

@fabioDMFerreira fabioDMFerreira commented Jun 21, 2022

Make writemarker and hashnode functions available to the integration tests bundle.

While running conductor tests we are getting next errors because the functions referred to are in a file that is not compiled on conductor tests.

Error: ../blobbercore/handler/handler.go:81:64: undefined: LockWriteMarker
Error: ../blobbercore/handler/handler.go:82:77: undefined: UnlockWriteMarker
Error: ../blobbercore/handler/handler.go:84:61: undefined: LoadRootHashnode

@fabioDMFerreira fabioDMFerreira changed the title Fix blobber compilation Fix blobber compilation for conductor tests Jun 21, 2022
@dabasov dabasov requested a review from cnlangzi June 22, 2022 11:00
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabioDMFerreira please fix ci errors first

@codecov-commenter
Copy link

Codecov Report

Merging #735 (e578113) into staging (784fb36) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           staging     #735   +/-   ##
========================================
  Coverage    24.15%   24.15%           
========================================
  Files           69       69           
  Lines         7913     7913           
========================================
  Hits          1911     1911           
  Misses        5718     5718           
  Partials       284      284           
Flag Coverage Δ
Unit-Tests 24.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...0chain.net/blobbercore/handler/handler_hashnode.go 57.14% <ø> (ø)
...ain.net/blobbercore/handler/handler_writemarker.go 64.70% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 784fb36...e578113. Read the comment docs.

@cnlangzi cnlangzi merged commit 3cc23dd into staging Jun 24, 2022
@cnlangzi cnlangzi deleted the fix/blobber-conductor-tests branch June 24, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants