Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New single balance ReadPool #723

Merged
merged 1 commit into from
Jun 13, 2022
Merged

New single balance ReadPool #723

merged 1 commit into from
Jun 13, 2022

Conversation

iamrz1
Copy link
Contributor

@iamrz1 iamrz1 commented Jun 12, 2022

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

Codecov Report

Merging #723 (2c532b6) into staging (ee6faea) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           staging     #723      +/-   ##
===========================================
+ Coverage    24.18%   24.19%   +0.01%     
===========================================
  Files           69       69              
  Lines         7907     7899       -8     
===========================================
- Hits          1912     1911       -1     
+ Misses        5710     5704       -6     
+ Partials       285      284       -1     
Flag Coverage Δ
Unit-Tests 24.19% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ode/go/0chain.net/blobbercore/allocation/entity.go 0.00% <0.00%> (ø)
...et/blobbercore/handler/object_operation_handler.go 32.48% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee6faea...2c532b6. Read the comment docs.

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests single-balance-readpool
gosdk NOT OVERRIDDEN
zboxcli single-balance-readpool
zwalletcli staging
0chain single-balance-readpool
blobber single-balance-readpool
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests single-balance-readpool
gosdk NOT OVERRIDDEN
zboxcli single-balance-readpool
zwalletcli staging
0chain single-balance-readpool
blobber single-balance-readpool
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 3690c77 into staging Jun 13, 2022
@cnlangzi cnlangzi deleted the single-balance-readpool branch January 29, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants