Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to json format for _stats API #663

Merged
merged 4 commits into from
May 2, 2022
Merged

Add support to json format for _stats API #663

merged 4 commits into from
May 2, 2022

Conversation

shaktals
Copy link
Contributor

@shaktals shaktals commented Apr 27, 2022

Changes

Adds support for API consumer to specify Accept request header as applicaton/json so that the response complies with that format.

Fixes

#508

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

@shaktals shaktals requested a review from peterlimg April 27, 2022 00:54
@shaktals shaktals requested review from Kishan-Dhakan, cnlangzi and lpoli and removed request for Kishan-Dhakan and peterlimg April 28, 2022 21:05
@codecov-commenter
Copy link

Codecov Report

Merging #663 (ae880b7) into staging (88b50cb) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           staging     #663      +/-   ##
===========================================
- Coverage    19.79%   19.67%   -0.12%     
===========================================
  Files           66       66              
  Lines         7482     7527      +45     
===========================================
  Hits          1481     1481              
- Misses        5774     5819      +45     
  Partials       227      227              
Flag Coverage Δ
Unit-Tests 19.67% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
code/go/0chain.net/blobbercore/handler/handler.go 57.48% <0.00%> (-5.15%) ⬇️
...o/0chain.net/blobbercore/handler/handler_common.go 23.76% <0.00%> (-2.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b50cb...ae880b7. Read the comment docs.

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shaktals shaktals merged commit 894e579 into staging May 2, 2022
@shaktals shaktals deleted the _stats-json branch May 2, 2022 18:35
@cnlangzi cnlangzi linked an issue May 6, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_stats vs _statsJSON
3 participants