Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/go18 #657

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Fix/go18 #657

merged 3 commits into from
Apr 26, 2022

Conversation

cnlangzi
Copy link
Contributor

Changes

Fixes

  • fixed action@setup-go with 1.18 on all workflows

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

Codecov Report

Merging #657 (2e229a6) into staging (ad877da) will decrease coverage by 0.18%.
The diff coverage is 8.33%.

@@             Coverage Diff             @@
##           staging     #657      +/-   ##
===========================================
- Coverage    19.98%   19.79%   -0.19%     
===========================================
  Files           66       66              
  Lines         7396     7481      +85     
===========================================
+ Hits          1478     1481       +3     
- Misses        5692     5773      +81     
- Partials       226      227       +1     
Flag Coverage Δ
Unit-Tests 19.79% <8.33%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/go/0chain.net/blobbercore/filestore/fs_store.go 0.00% <ø> (ø)
code/go/0chain.net/blobbercore/handler/handler.go 62.63% <0.00%> (ø)
code/go/0chain.net/blobbercore/handler/health.go 0.00% <0.00%> (ø)
code/go/0chain.net/blobbercore/handler/protocol.go 0.00% <0.00%> (ø)
code/go/0chain.net/blobbercore/handler/context.go 34.93% <14.89%> (-8.32%) ⬇️
...ain.net/blobbercore/handler/handler_writemarker.go 64.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922ea95...2e229a6. Read the comment docs.

Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit 32afc97 into staging Apr 26, 2022
@cnlangzi cnlangzi deleted the fix/go18 branch April 26, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants