Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty chunk on eof #1417

Draft
wants to merge 2 commits into
base: sprint-1.14
Choose a base branch
from
Draft

fix empty chunk on eof #1417

wants to merge 2 commits into from

Conversation

Hitenjain14
Copy link
Member

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 18.18182% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 14.92%. Comparing base (8329e36) to head (a72c4f0).
Report is 81 commits behind head on sprint-1.14.

Files Patch % Lines
...ode/go/0chain.net/blobbercore/filestore/storage.go 10.00% 8 Missing and 1 partial ⚠️
...ain.net/blobbercore/handler/file_command_update.go 0.00% 6 Missing ⚠️
...ain.net/blobbercore/handler/file_command_upload.go 50.00% 1 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           sprint-1.14    #1417      +/-   ##
===============================================
- Coverage        15.02%   14.92%   -0.11%     
===============================================
  Files              178      179       +1     
  Lines            19922    20183     +261     
===============================================
+ Hits              2994     3013      +19     
- Misses           16556    16795     +239     
- Partials           372      375       +3     
Flag Coverage Δ
Unit-Tests 14.92% <18.18%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants